Skip to content

Pass image dpi to shapes, fix text shape not updating dpi properly

Alvin Wong requested to merge alvinwong/krita:alvin/text-shape-dpi into master

Funnel the image resolution from KisShapeLayerCanvas through KoShapeManager to the KoShape instances. This allows KoSvgTextShape to get the image resolution outside of paintComponent.

The previous approach of calculating the resolution in paintComponent did not work well because shapes are cloned to be painted in an update job. This meant the original shape never actually gets the proper dpi and layout, which causes the shape outline to become out of sync with the painted shape. This had significant issues for fonts containing bitmap glyphs, which gives drastically different metrics under different dpi. (It also meant text shapes always do a relayout whenever they are painted.)

CCBUG:472566

Test Plan

(Tell us how to test the changes you made.)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports