Skip to content

Fix dockers etc getting hidden on unminimize

Freya Lupen requested to merge freyalupen/krita:freyalupen/fix-dockers-hiding into master

adjustLayoutForWelcomePage is called in KisMainWindow::showEvent, which gets called on opening a window, but it also gets called on unminimizing, at least on Windows. The latter calls are 'spontaneous' unlike the former, so we can ignore those.

This problem doesn't seem to happen on Linux, I haven't tested other platforms. The patch I've only tested on Windows, I don't think it should cause problems on other platforms.

Test Plan

Open a document, minimize and unminimize the Krita window. The dockers, status bar, and 'brushes and stuff' toolbar shouldn't become hidden.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports