Skip to content

Ensure pen stylus brush (opposed to eraser stylus brush) is selected on new document

R. B. requested to merge tomtomtom/krita:tomtomtom/inputdeviceeraser into master

The following issue currently exists: If the user exits Krita in eraser stylus mode, either from flipping the stylus or from using 5.2's Toggle Eraser Preset" action, creating a new document will set the pen stylus brush to the eraser brush.

Steps to reproduce above:

  1. Flip stylus to eraser mode.
  2. Make sure an eraser brush is selected.
  3. Restart Krita and create a new document.
  4. The pen stylus mode now uses the eraser stylus brush, meaning both modes will now use the same eraser brush.

This MR should ensure that the correct pen stylus brush is used on document creation.

Test Plan

  • Make sure the issue is fixed.
  • Make sure the correct pen brush and the correct eraser brush are remembered properly after swapping around brushes in various input modes, as the relevant config settings seem dependent on the stylus.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports