Skip to content

Add explicit actions for selecting the remembered presets for the pen stylus and eraser stylus

R. B. requested to merge tomtomtom/krita:tomtomtom/eraserselectshortcuts into master

While !1689 (merged) added a method to toggle the eraser stylus brush, not every user (such as myself) is comfortable with a toggling workflow for brush selection. Two additional actions for explicitly selecting the eraser or brush preset would be more comfortable for those who would like to twitch their fingers between the two modes, and would be closer to how software like CSP handles brush/eraser activation.

These two actions also automatically select the freehand brush tool, unlike the toggle action.

Test Plan

Ensure the two actions select the correct brush and also automatically activate the freehand brush tool. Ensure these actions highlight properly as toolbar items.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports