Skip to content

Fix SVG text-transform param 'none'

Freya Lupen requested to merge freyalupen/krita:freyalupen/text-transform-none into master

Make sure "none" text-transform parameter is parsed, rather than going to 'unknown parameter'. It seems it should clear any transforms.

Test Plan

Create a piece of text, add "text-transform:none;" to the SVG style. Unknown parameter in text-transform "none" shouldn't be logged. "text-transform:lowercase none;" or the like should get interpreted as "none" instead of "lowercase", while "none lowercase" is interpreted as "lowercase", as the parser seems to apply params from left to right.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports