Skip to content

Simplify XML Parsing for Resource Bundles

Quytelda Kahja requested to merge quytelda/krita:quytelda/qtxml into master

This merge request simplifies XML parsing code in KoResourceBundle and KoResourceBundleManifest.

This is a continuation of the work in !1804 (merged) and !1821 (merged).

Test Plan

These patches don't implement any new functionality, so existing unit tests apply.

I manually tested creating and importing bundles, and everything loaded correctly. It also correctly loaded a bundle I created outside of Krita. I don't have any extremely old bundles to test for backward compatibility, though.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports