Skip to content

Simplify similar color selection tool and add spread option

Deif Lou requested to merge deiflou/krita:deiflou/simplify_similar_selection_tool into master
  • Removed some unused code in the contiguous selection tool
  • Changed the similar selection tool to use KisFillPainter::createSimilarColorsSelectionJobs to generate the selection. This removes considerable amount of code.
  • Also adds the spread option used on the other tools to the similar selection tool.
  • And the threshold range in the similar selection tool was also changed to [0, 100]. It was [0, 200] for some reason. Now it is the same as in the other tools.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports