Skip to content

Holding ctrl while using measure tool will change the baseline to the direction of the measure line

Bip Boop requested to merge bipboop/krita:measure_tool_choose_baseline into master

Holding the ctrl key sets the baseline to the current measure line to measure angles with non horizontal baseline

https://bugs.kde.org/show_bug.cgi?id=417813

Test Plan

Set the measure tool to an arbitrary angle Hold ctrl and move the cursor The angle should be computed between the new baseline and the measure line

Each time ctrl is pressed, the baseline is set to a new vector When the tool is reinvoked, it is reset to horizontal

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports