Skip to content

Draft: text: Handle white-space hanging in text layout

Alvin Wong requested to merge alvinwong/krita:alvin/bug472829-whitespace-hang into master

Implemented according to css-text-3 section 4.1.2 point 4: https://www.w3.org/TR/css-text-3/#white-space-phase-2

BUG:472829

I am not really sure if this is 100% correct. I only tested with the limited test cases I have. Also this is missing tests...

Test Plan

Test with file: white-space-hanging.kra

Render with debug bounding boxes 圖片

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports