Skip to content

Fix comparison of double spin box

Jasper Hartog requested to merge jasperh/krita:409818-specific-color-selector-2 into master

I made sure that the advanced color selector can be updated from an outside event, which I probably should have checked in my previous merge request... The double spin box now checks correctly if the new value differs from the old value, since it previously didn't took into account that the old value was rounded down.

Test Plan

  1. Open the specific color selector, set channel to floats.
  2. Make sure that the specific color selector changes when a color is picked with the color picker.
  3. Make sure that the double spin box doesn't transform directly when a fraction is entered, only when focus is lost or enter is pressed. Try for example 1/2, 1/3, 1/4.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports