Skip to content

Make halftone filter work well with python

Deif Lou requested to merge deiflou/krita:deiflou/halftone_python into master

The generator configurations are cached, so we need to check if the property name of a property being set represents a property of a generator configuration, and in that case we must remove the cache entry that property belongs to, so that the configuration can be regenerated later. This is an issue mainly when setting the properties directly (through python for example) instead of using the high level methods.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports