Skip to content

Allow empty slots in Ten Scripts plugin

Before, setting a script to a slot with empty slots before it would move it to the first empty slot, which is confusing.

Test Plan

  1. Clear [tenscripts] scripts in kritarc if there's no empty slots, since there's no way to remove scripts from the UI.
  2. Open Tools->Scripts->Ten Scripts, add a script to slot 10. Hit "OK" and then use the slot 10 shortcut or reopen the dialog, the script should stay in slot 10.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports