Skip to content

Don't allow New/Open File buttons to grow taller

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-473509 into master

Don't allow New/Open File buttons on the Welcome Page to grow taller, because it causes them to look strange. The horizontal sizePolicy changes are to keep the position of the shortcut text the same.


With 1.25x display scaling, before:




(Ignore the dark horizontal line, I don't know why that happens on my local build.)

Test Plan

  1. Use 1.25x display scaling.
  2. Open the Welcome Page with the window fullsize. The buttons should no longer be tall.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list,

Merge request reports