Skip to content

flake: Make sure generated ID when saving SVG is unique

Alvin Wong requested to merge alvinwong/krita:alvin/svg-no-duplicate-id into master

Make sure the generated ID of shapes when saving SVG is unique. Previously the code often generated duplicated IDs in some cases.

Test Plan

  • Create a file with some text shapes
  • Save the file, close it, then reopen the file
  • Add more text shapes
  • Save the file and inspect the layer content.svg for duplicated IDs

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports