Skip to content

Edit Shapes tool: replace old and inaccessible mouse cursors with OS-provided ones

liquidex woźniak requested to merge liquidev/krita:path-tool-remove-old-crusty-cursors into master

I'm replacing the idle cursor with the default arrow and the moving cursor with the north-east-south-west "compass" (because that is often used for indicating that things are movable.)

Reasons for this change:

  • these cursors are not visible at all against a dark background because they're pure black
  • the cursors are hard to read because they're very small and narrow
  • the cursors do not scale with the user's DPI scale

https://bugs.kde.org/show_bug.cgi?id=467546

Test Plan

  1. Open Krita.
  2. Create a new document.
  3. Fill the background with #000000 black.
  4. Create a vector layer.
  5. Draw a Bézier curve on that vector layer.
  6. Edit the curve.
  7. Observe the changed cursors.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
    • ☝ I'm not sure this sort of vanity functionality is unit tested? I didn't change any behavior in this MR, only appearance.
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports