Skip to content

flake: Fix transformation of text path and shape-inside

Shapes referenced by text path and shape-inside should ignore any transformation of their parents. When the shapes are loaded from SVG, they have the absolute transformation baked in. In order to get the transform we need, we invert the transform of a shape's parent and combine it with the shape's own absolute transform.


Test Plan

The text-on-path in these files should look the same as in Inkscape. The text-in-shape in the second file should also look similar as in Inkscape, but not exactly due to some differences in line positioning.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list,

/cc @woltherav

Edited by Alvin Wong

Merge request reports