Skip to content

OpenGL: Request DeprecatedFunctions on Windows to fix Intel driver

Alvin Wong requested to merge alvinwong/krita:alvin/intel-opengl-deprecatedfunctions into master

Some parts of Qt seems to require deprecated functions. On Windows with the Intel Graphics driver, things like canvas decorations and the Touch Docker does not render without this option. It was previously removed in 2aef8841 (MR !1726 (merged)).

BUG:473782

Test Plan

  • Check that canvas decorations and touch docker can be rendered on Intel graphics on Windows.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports