Skip to content

text: Draw a hex tofu block for missing glyphs and add a fix to raqm

Alvin Wong requested to merge alvinwong/krita:alvin/hex-missing-glyph into master

This implements drawing a hex glyph for missing glyphs like Firefox does.

圖片圖片

This MR also includes a fix for raqm to fix Unicode codepoint conversion from UTF-16. !1928 (merged) (Upstream PR: https://github.com/HOST-Oman/libraqm/pull/192)

I don't think the hex glyph should be backported to 5.2, but the raqm patch should be backported as it should be an important fix (extracted to !1928 (merged)).

Test Plan

(Tell us how to test the changes you made.)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

/cc @dkazakov

Edited by Alvin Wong

Merge request reports