Skip to content

Fix multiple issues with auto-keyframing code

Dmitry Kazakov requested to merge dkazakov/krita:kazakov/auto-keyframe-fixes into master

  1. Make sure that Delete/Backspace key shortcuts now auto-create a frame (it is a standard procedure for paitners for frame creation)

  2. Deduplicate the autokeyframing code in different places, so now it properly handles (some places, e.g. move tool handled them incorrectly):

    * Instant Preview
* Frame Labels

  3. Make sure that the icon for the auto-keyframe button is properly initialized on start

  4. Fix the threading issue for reading from KisAutoKey::activeMode(). We cannot read from a KConfig fron non-GUI threads, since KSharedConfig has per-thread copies of the config, which are never synchronized. Hence now we have AutoKeyFrameStateHolder, which listen to the updates in the GUI thread.

  5. The patch also fixes an issue in MoveStrokeStrategy, when the autokey command was called before initStrokeCallback(), which caused undo to be broken.

Merge request reports