Skip to content

Draft: Some rvalue optimization

Fushan Wen requested to merge work/fuf/rvalue into master

By using rvalue overloads, two atomic ref operations are reduced.

If an image is being used by QPainter, in QImage's ctor it will always copy the referenced image, which is expensive. So make sure an image is freed from QPainter before assigning it to other places.

See also https://github.com/qt/qtdeclarative/commit/ff0cbaeba3dfc11dde5445b9ea919f1ae137ea2f

Test Plan

There is no behavior change. If it builds, it works.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Fushan Wen

Merge request reports