Skip to content

Fix setting size of text brushtip

Freya Lupen requested to merge freyalupen/krita:freyalupen/text-brushtip-size into master

A QString was being passed to KisTextBrush::setFont(const QFont& font), and somehow this resulted in attempting to set an invalid font like Apple Color Emoji,48,-1,5,50,0,0,0,0,0,Regular,12,-1,5,50,0,0,0,0,0 instead of Apple Color Emoji,48,-1,5,50,0,0,0,0,0,Regular.

Having setFont() accept a QString instead and then converting to a QFont it works fine.

Test Plan

Set a brush to use a text brushtip, change its font size. The brush size should change accordingly.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports