Skip to content

Fix layer selection menus piling up until closing the canvas

Mathias Wein requested to merge mwein/krita:layer-menu-leak into master

I noticed this more or less by chance while looking into something. The menus stay in memory until you close the canvas widget (I verified by connecting a debug print to the destruction signal), and each usage of "Select from Menu" from the layer selection canvas actions allocates a new menu.

On a closer look, the menu also indirectly holds shared pointers to image nodes, so I guess they might potentially keep a lot of memory form being freed, not just a menu widgets themselves...

I'm not sure if setting the Qt::WA_DeleteOnClose attribute is a nice solution, but this widget gets created "in the wild" without telling any other part of Krita about it.

Test Plan

There's always a chance I missed some potential crash... The action is not assigned by default from what I can tell, so you first have to go into Configure Krita -> Canvas Input Settings -> Select Layer and create/modify and action to "Select From Menu (Replace Selection)" or "Select From Menu (Add to Selection)".

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports