Skip to content

Fix SEGFAULT in KoColorSet unit tests

Quytelda Kahja requested to merge quytelda/krita:quytelda/fix-TestKoColorSet into master

This MR fixes a SEGFAULT discovered by the unit test additions in 604ba050.

The cause of the SEGFAULT is the deletion of a dangling pointer in the destructor for KoColorProfileStorage::Private. The offending pointer should actually be removed from the duplicates list by a call to removeProfile() since it will probably be freed afterwards.

This change also removes a redundant conditional in removeProfile().

Test Plan

The unit test libs-pigment-TestKoColorSet passes (as before), but no longer SEGFAULTS on completion.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports