Skip to content

Fix Channel scripting API's pixel data handling

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-475456 into master

Channel.pixelData and Channel.setPixelData were both broken.

BUG:475456

Test Plan

Test either the bug report's script (which expects RGBA) or the following script, with each of int8, int16, float16, float32. This script should make a copy of the current layer.

from krita import * 

doc = Krita.instance().activeDocument()
activeNode = doc.activeNode()
rect = activeNode.bounds()

newNode = doc.createNode("channels copy", 'paintlayer')
for i in range(0,len(newNode.channels())):
    newNode.channels()[i].setPixelData(activeNode.channels()[i].pixelData(rect), rect)

doc.rootNode().addChildNode(newNode, None)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports