Skip to content

Implement text selection with the mouse cursor.

Wolthera van Hövell requested to merge woltherav/krita:text-tool-phase-1-selection into master

This adds a strategy to the SVG text tool to allow selecting text with the pointer-cursor instead of only by text-caret.

Test Plan

  • Create a text with the text tool (or load one).
  • Click+drag anywhere on the text to select.
  • Double click to select the whole word under the cursor.
  • Triple click to select the whole paragraph. (This is the behaviour simple text-editors like Firefox' and Kate use, but word processors select whole sentences instead, we could do this, but the question is whether it is worth it?)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports