Skip to content

Add AngleSelector widget to Python API

Freya Lupen requested to merge freyalupen/krita:freyalupen/py-angleselector into master

This wraps KisAngleSelector so it can be used from Python, AngleSelector for the functions and AngleSelector.widget() for the widget itself. I wasn't sure if there's a better way to do this, or the proper way to handle the enums for FlipOptionsMode and IncreasingDirection.

I'd also like to look into doing the same for Kis(Double)SliderSpinBox after this.

Test Plan

  1. Before recompiling, delete [buildfolder]/plugins/extensions/pykrita/sip/_tmp so that the Python bindings will be regenerated.
  2. Use this script: https://invent.kde.org/-/snippets/2879 in the Scripter to test AngleSelector's functions, as shown in the image.

angle-selector-testscript

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports