Skip to content

Changed duplication button render code to comply with the light/dark icon loading system

Aries Moczar requested to merge arcmantis/krita:aries/assistant-tool-themes into master

I was notified that the duplication button for the assistant tool was blending in with the background when Krita was using bright themes. I changed the render code to comply with Krita's icon light/dark allocation rules. In addition, the duplication button is now drawn depressed using opacity rather than the dark version of the icon.

Test Plan

Start Krita with the 'bright' theme. Go to the assistant tool and draw an assistant. The duplication button will now be coloured dark or light according to the theme.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports