Skip to content

Draft: FIx OpenJPEG include dir path

Amedeo Molnár requested to merge neko/krita:neko-master-patch-84658 into master

Hi there,

I changed a variable name in cmake/modules/FindOpenJPEG.cmake to make the openjpeg headers accessible for my build. Otherwise I would get following compilation error:

/build/krita-5.2.0/plugins/impex/jp2/jp2_converter.cc:9:10: fatal error: openjpeg.h: No such file or directory
    9 | #include <openjpeg.h>
      |          ^~~~~~~~~~~~
compilation terminated.
make[2]: *** [plugins/impex/jp2/CMakeFiles/kritajp2import.dir/build.make:104: plugins/impex/jp2/CMakeFiles/kritajp2import.dir/jp2_converter.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:36732: plugins/impex/jp2/CMakeFiles/kritajp2import.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

I'm currently running NixOS 23.11pre
The openJPEG library version is 2.5.0

Test Plan

Other than to test builds on different Distros, I have no clue how to test that.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Amedeo Molnár

Merge request reports