Skip to content

Hide perspective ellipse if assistants are globally hidden

Maciej Jesionowski requested to merge yavn/krita:hide-persp-ellipse into master

This patch fixes a bug where unchecking "View > Show Painting Assistants" would not affect the perspective ellipse assistant.

It also adds a preview stroke when the cursor is inside the bounding box of the assistant.

The bug -- the ellipse should not be visible:

Screenshot_2023-11-05_000920

Notes

  • I removed the check for isAssistantComplete() because it's already done in isEllipseValid().
  • I didn't see this bug reported in KDE tracker, just noticed it while using Krita.
  • I tried to make the behavior similar to the regular ellipse assistant.

Test Plan

  1. Create a new document and add a perspective ellipse assistant.
  2. Switch to the brush tool.
  3. Uncheck View > Show Painting Assistants
  4. The perspective ellipse assistant should disappear.
  5. Move the cursor to where the assistant is located. The ellipse preview should appear.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports