Skip to content

Bulk cherry-pick to 5.2 (brush rotation, perspective ellipse fix)

Maciej Jesionowski requested to merge yavn/krita:cherry-pick-brush-rotation-persp-ellipse into krita/5.2

It seems that many people wanted to use brush rotation hotkeys and UI, so I wanted to port it back to 5.2 release branch. I think we should do it, unless 5.3 is not that far away.

Features in this MR

Risk Assessment

Based on my understanding, the risk is low. Everything cherry-picked cleanly. No changes to existing enums or APIs were made. The patches add a new resource provider enum and new Python functions in the View class.

Test Plan

I checked the build on Windows in 5.2 branch, tested the UI and Python, tested the ellipse behavior. Shortcut Composer plugin is also working with the rotation.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports