Skip to content

Fix Specific Color Selector changing to black

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-476614 into master

The Specific Color Selector's color wasn't initialized, so it showed black. Switching HSX mode would set the view's foreground color to this black. Whether RGB or HSX was checked wasn't being saved, either.

BUG:476614

Test Plan

  1. Pick a foreground color that's not black. Switch the Specific Color Selector to use HSL, HSI, or HSY.
  2. Restart Krita.
  3. The Specific Color Selector should still show the current foreground color and remember if HSX was selected.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports