Skip to content

Implement SVG paint-order property.

Wolthera van Hövell requested to merge woltherav/krita:svg-paint-order into master

The SVG 2 paint-order property allows artists to choose in which order they want the fill, stroke and markers to be painted. Which is particularly useful for text, where painting the stroke before the fill will give nicer results both in terms of legibility, as well as dealing with the multiple paths a glyph may have due to being a joined script or variable font.

image

This is probably the most commonly supported SVG 2 property.

Test Plan

  1. Make a file with vectors and text. Set stroke and markers.
  2. Use the new dropdown in the geometry widget to change the paint order.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports