Skip to content

Rework i18n of spinboxes to simplify common use cases and fix some regressions

Alvin Wong requested to merge alvinwong/krita:alvin/spinbox-i18n-rework into master
  • Don't install a plural handler for the more common static prefix/suffix cases. Also fixes warnings like kf.i18n: "1 instead of 0 arguments to message {Opacity: {n}%} supplied before conversion." that ki18n may produce in some versions.
  • Restore the different prefix for the opacity and saturation sliders in the reference image tools when multiple reference images are selected with differing properties, which also fixes their initial display (regression from !1963 (merged)).
  • Restore some i18nc context removed in !1999 (merged).

Test Plan

Check the slider/spinboxes.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

/cc @esari

Merge request reports