Skip to content

Use PreciseTimer type with KisPlaybackEngineQT

Maciej Jesionowski requested to merge yavn/krita:fix-qt-playback-fps into master

This fixes the erratic playback of frames. A precise timer is needed to achieve 1 ms accuracy.

I'm adding another commit with warning fixes that I noticed. It's best to not squash them.

I would like the fix commit to be ported to 5.2 branch, please, as it was affecting several users! More information in the posts:


Test Plan

See the steps in

Also worth checking the frame rate of 31 FPS, as that had the largest error. I'm not sure if the error is as big on Linux, but it was confirmed on Windows.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list,

Merge request reports