Skip to content

Text: Caret improvements.

Wolthera van Hövell requested to merge woltherav/krita:text-tool-phase-1-caret-improvements into master

This adds a number of improvements to the blinking cursor/ caret:

  • Caret is drawn with text color and a black or white outline depending on whether the text-color has a higher than 80% brightness.
  • Some fixes to the bidi-caret flag and slanted carets.
  • We had too little info for carets on some bitmap fonts, so that's fixed too.
  • The canvas controller will ensure the text caret remains visible when typing.
  • [BIG] Focus event handling has been added to KoToolBase so we can stop the caret from blinking when the canvas is out of focus.
    • The blink limit may need to be raised. Ideally we'd get it from system config if possible, but KDE itself does not have such a thing (Gnome and Windows do...)
  • Some fixes and tests for text-deletion.
  • And a fix for the cursor sometimes disappearing.

Test Plan

Try out the text tool on a number of text shapes with different colors over different backgrounds.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports