Skip to content

Replace fcitx-qt5 with fcitx5-qt.

Wolthera van Hövell requested to merge woltherav/krita:replace-fcitx-dep into master

This replaces fcitx-qt5 with fcitx5-qt. The latter is more frequently updated.

Test Plan

What needs to happen is that an appimage with this dep is build so @alvinwong can check if it works better. (The current implementation has odd text-decoration).

Formalities Checklist

  • [n/a] I confirmed this builds.
  • [n/a] I confirmed Krita ran and the relevant functions work.
  • [n/a] I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • [n/a] I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • [n/a] I made sure my code conforms to the standards set in the HACKING file.
  • [n/a] I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports