Skip to content

Remove 'updateInputMethodInfo' and the passed view converter on the IME query.

Wolthera van Hövell requested to merge woltherav/krita:remove-unnecessary-ime-stuff into master

This removes some of the extraneous IME stuff that was still part of Krita.

The former uses qApp functionality while the latter is unnecessary as the canvas is always available to a tool and has all the converters available.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports