Skip to content

Implement two new ways of using the snapguide.

Wolthera van Hövell requested to merge woltherav/krita:snap-to-line into master

Some of the snap strategies will use only the vertical or horizontal component to snap. This can be a problem when trying to get snapping to work on the end of a line. For this 'snapWithLine' was implemented, which instead checks intersections when evaluating these points.

Other times, you might want to snap with multiple points in mind, such as when snapping a bounding box. For this, snapWithPolygon was implemented, which will try to snap to the point on the polygon that's closest to snap.

Test Plan

  • snapWithLine is currently only implemented in the text tool when adjusting the inline size.
  • snapWithPolygon is currently only implement when moving a text with the text tool. The ends of the outline rect as well as the initial text pos can all be snapped to.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports