Skip to content

Update kis_selection_options.cc

Qw As requested to merge kdeusrnm/krita:kdeusrnm-master-patch-55180 into master

When using the Select menu and choosing the Feather Selection option, the Feather of a selection can be set up to 100,000 pixels. This allows a gradient effect (soft feathers) when using the selection tool.

sliderFeatherSelection in the widget or docker was limited to 40px, creating harsh feathers. Value of Max Range increased from 40 to 400 to allow the soft feathering, achievable through the select menu.

Test Plan

the Tool Options Docker now goes from 0 to 400px instead of being limited to 40px.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports