Skip to content

WEBP & JPEG-XL: preemptive check for animation

Rasyuqa A H requested to merge rasyuqaa/krita:rasyuqaa/webp-jxl-anim-export-fix into master

BUG: 476761

Add an animation check before entering the conversion.

When Save as animated option is enabled, double checking whether:

  • animationInterface has animation, and
  • flattened projection also has animation.

If one of those are false, export as a non-animated WebP/JXL instead of error / crashed out.

Other notable finding: apparently importing a static WebP image to Krita seems to trigger an animation interface even though it only has a single frame? Haven't checked the import code further though.

Test Plan

  • Open a static / single frame WebP image in Krita
  • Export to WebP or JPEG-XL with Save as animated option enabled

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports