Skip to content

WebP: assortment color profile fixes

Rasyuqa A H (Kampidh) requested to merge rasyuqaa/krita:rasyuqaa/webp-assortment-color-fix into master

This fixes the color profile not being saved properly. However this only works with RGBA model, other color models will always get converted into RGBA with sRGB profile (QImage default) as WebP only accepting RGB/RGBA buffers. Their profiles are still saved, though it may result in gamut clipping if there are out-of-gamut colors. Maybe need to update docs for this behavior?

This fixes segfault when importing WebP images with non-RGB color profile models, and attempting to convert it back to the original color profile. However, this converting behavior might be different from the other apps (eg. in GIMP it throws out error and importing it as an sRGB image instead), because as stated above WebP IO buffers are in RGB/RGBA only (https://developers.google.com/speed/webp/docs/api).

Test Plan

For BUG: 477219 :

  • Export an image to WebP with a non-sRGB, RGBA color model profile (eg. BGR as in the bug report)
  • Check whether profile and appearance is still correct on import.

For BUG: 478307 :

  • Import an WebP image with non-RGBA color model (eg. grayscale)
  • Check whether the image is imported successfully.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports