Skip to content

Replace maskSyntheticEvents with disableTouchOnCanvas

Wolthera van Hövell requested to merge woltherav/krita:cleanup-touch-on-canvas into master

Because the text tool needs to allow setting the cursor by touch when text is being edited, we need to be able to set disable-touch-on-canvas via the tool. This replaces the somewhat specific maskSyntheticEvents with disableTouchOnCanvas so that all tools can set by themselves whether they allow touch. Similarly, every tool right now sets the touchDisabled to use the config 'enable touch painting' value, with exception of the text tool in text editing mode.

Some problems:

  • I can't seem to figure out how to reset the touch gesture shortcuts. I'm trying to call profileChanged() but it doesn't seem to do anything. [Fixed]
  • toggling touch painting in the config seems to require restarting krita. Is that because each tool is now setting it in the intializer while it should actually use some config notifier?

Test Plan

first:

  • Have touch painting disabled
  • Start text editing with a mouse/stylus.
  • try to change the cursor position by finger.

second:

  • have touch painting enabled
  • try every tool to see if touch does something.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Wolthera van Hövell

Merge request reports