Skip to content

Fix invalid XML in bundle metadata (meta.xml) file.

Quytelda Kahja requested to merge quytelda/krita:quytelda/fix-bundle-metadata into master

The "meta" and "dc" namespaces in the metadata file should be declared as specified in the OpenDocument schema. QtXml doesn't complain about this currently, but some parsers fail when namespaces are undeclared (e.g. python's minidom).

I found information about the relevant URLs here: https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html

The cd:creator tag in the bundle metadata file (meta.xml) should actually be dc:creator. This appears to be the result of a typo in 7bf66b17, since the correct form appears prior.

Test Plan

  1. Create a new bundle.
  2. Open a new instance of Krita with a different resource directory (e.g. env HOME=/some/dir krita).
  3. Import the bundle, and verify that all relevant metadata is loaded

Python's built-in minidom can validate the generated XML. First extract the meta.xml file from the bundle, then using a python interpreter:

>>> import xml.dom.minidom as MD
>>> MD.parse('deevad/meta.xml')
<xml.dom.minidom.Document object at 0x123456789abc>

The parse method would throw an exception if there are undeclared prefixes.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Quytelda Kahja

Merge request reports