Skip to content

Bump libjxl to 0.9.0

Rasyuqa A H (Kampidh) requested to merge rasyuqaa/krita:rasyuqaa/bump-libjxl-090 into master

This MR proposed to bump libjxl to 0.9.0 along with other supporting deps:

It is marked draft just in case libjxl rolls v0.9.1 soon thus removing the need for included CMYK patch file.

The second part is to have a workaround in KisFileIconCreator also applied for JXL thumbnails. In some cases if our libjxl is updated to 0.9.0 or more, the API changes can also affect our KImageFormats / QImage installation, and can crash Krita on welcome screen whenever JXL images trying to load its thumbnail. This patch also enables thumbnail preview for JXL images so it can visible now on welcome page.

Test Plan

  • Build deps (libjxl and the supporting deps)
  • Build Krita
  • Try to save/load JXL files
  • See if JXL image have thumbnails on welcome screen.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports