Skip to content

Add aspect ratio lock to Pixelize filter dialog

Freya Lupen requested to merge freyalupen/krita:freyalupen/pixelize-aspect-locker into master

This adds an aspect ratio lock to the Pixelize filter's width and height, and turns it on by default. However, the state of the lock isn't saved if unchecked.

The code seems a bit hacky, needing to search for the widgets and layout with findChild(). It would probably be better to refactor the widget...

Requested on KA here: https://krita-artists.org/t/append-chain-link-button-for-square-size-to-pixelize-filter/80939

Test Plan

Open the Pixelize Filter, check that the new aspect lock button works.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Freya Lupen

Merge request reports