Skip to content

Add colorspace lock to Specific Color Selector

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-478521 into master

Previously in the Specific Color Selector, unless the colorspace combobox was changed, the internal colorspace would match the layer, without changing the UI. When clicking the RGB/HSV button in a nonRGB layer, it would then hide itself despite the UI still being in RGB.

Now there's a lock button to indicate whether the colorspace should use the current layer or a colorspace specified by the user in the combobox, and the UI behaves accordingly.

Also, simplifies KisSpecificColorSelectorWidget::updateHsvSelector().

BUG:478521

Test Plan

Open a document that's RGBA, add a Filter Mask (which is greyscale). If the lock is on, the Specific Color Selector should switch colorspaces when switching between RGBA layer and filter mask. If not, it should stay in the chosen colorspace. If the chosen colorspace is RGBA, clicking the RGB/HSV button shouldn't make it disappear. Also, when switching to greyscale and back, the docker shouldn't still show the color as grey, but as it actually is.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports