Skip to content

Fixed recorder export being sped up by input fps

reinold rojas requested to merge reinoldrojas/krita:reinoldrojas/fix-recorder-result into master

Before this commit if a number higher than 30 was put for INPUT_FPS it would speed up the preview, preview transition, and extended result. This commit fixes the ffmpeg profiles so they properly take into account the INPUT_FPS.

BUG:461869

Also address second issue in this KA thread where the transition is sped up/cut off with higher input_fps numbers.

NOTE: I checked most of the export profiles but the openh264 profiles didn't work for me in the docker build with the latest ffmpeg from ffmpeg.org. I made the same changes to those profiles as the others so they should work if someone can help me test those.

Test Plan

Similar instructions to whats in the bug report:

  1. Create a new document, open the Recorder docker, set it to 1 second, and start recording.
  2. Scribble a little artwork for 5 minutes, so you get more or less 300 frames recorded.
  3. Try to export a video with "Input PFS" at 120, and preview/end-result to 6 seconds.
  4. Check the exported video and confirm the preview/end result is 6 seconds and that preview transition isn't shortened

Also worth checking with a small input_fps (ex: 2) to insure it doesn't prolong the preview/result.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by reinold rojas

Merge request reports