Skip to content

Fix wg selector popup flickering with shortcut

reinold rojas requested to merge reinoldrojas/krita:reinoldrojas/fix-wg-popup-flicker into master

Before this commit the wide gamut color selector would flicker/autosclose if you were moving the cursor when pressing the shortcut. This was because the cursor movement would immediately trigger a leave event as the popup was loading. This commit fixes that issue.

I tried to use similar logic to the kis_color_selector_base.cpp since it doesn't have this issue.

Currently set as draft as I want to try and fix the flickering for the wide-gamut shade selector

Discussed on KA here

Test Plan

  1. Set a shortcut to the wide-gamut color selector
  2. Use the shortcut while moving the cursor on the canvas
  3. The selector should popup and not autoclose/flicker

TO DO:

  • Fix the flickering for wide-gamut shade selector

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by reinold rojas

Merge request reports