Skip to content

reenable assistant preview for line tools

reinold rojas requested to merge reinoldrojas/krita:reinoldrojas/reenable-assistant-preview-line-tools into master

Re-enable assistant preview for the eclipse, rectangle, polygon, and polyline tools.

I didn't re-enable for the bezier curve and freehand path tool cause since they still have some artifacts with the previews.

Discussed on KA here

Test Plan

  1. Put some assistants on the canvas with the assistant tool (easiest to check if you use the parallel ruler)
  2. Make sure previews are enabled in the view -> show assistant previews
  3. Draw on the canvas with the eclipse, rectangle, polygon, and polyline tools (there should be no artifacts)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports