Skip to content

Default export file type setting

Ken Lo requested to merge kenlo/krita:default-export-file-type-setting into master

Feature request from krita forum

Implemented a setting in configure Krita -> File Handling -> Default Export Filetype Created an option to pick your default export file type. Situations include:

  • New file without extension-> file type filter is setting default file type
  • Open File with extension -> file type filter is setting default file type
  • User picks a different file type (compared to the one in the setting) on the export file dialog -> file type filter is last used export(until user restarts krita or lastExportLocation isn't empty).

Decided it was best to keep this feature limited to exporting because most users would like to save as the same file type.

Test Plan

I recommend changing the drop down setting in File Handling and going through the situations I listed above and then press Export to look at the Files of Type filter.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Ken Lo

Merge request reports

Loading